✨ feat(login): show targeted wrong-password message for merged sim4life accounts ⚠️ 🚑#9035
Merged
giancarloromeo merged 35 commits intoITISFoundation:masterfrom Apr 21, 2026
Conversation
giancarloromeo
added
the
a:webserver
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9035 +/- ##
==========================================
+ Coverage 87.35% 89.54% +2.19%
==========================================
Files 2056 1722 -334
Lines 80971 68603 -12368
Branches 1451 585 -866
==========================================
- Hits 70732 61432 -9300
+ Misses 9828 7020 -2808
+ Partials 411 151 -260
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
giancarloromeo
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
giancarloromeo
changed the title
GitHK
reviewed
Apr 17, 2026
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
…thub.com:giancarloromeo/osparc-simcore into feat/targeted-wrong-password-msg-merged-accounts
GitHK
approved these changes
Apr 20, 2026
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
Thanks a lot, much better.
pcrespov
approved these changes
Apr 20, 2026
giancarloromeo
changed the title
matusdrobuliak66
approved these changes
Apr 21, 2026
|
matusdrobuliak66
approved these changes
Apr 21, 2026
giancarloromeo
deleted the
feat/targeted-wrong-password-msg-merged-accounts
branch
giancarloromeo
added a commit
that referenced
this pull request
Apr 21, 2026
…fe accounts⚠️ 🚑 (#9035)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request enhances the login error handling to support users affected by the databases merge. It introduces logic to detect users who belong to both merged products and provides them with a targeted error message when they enter the wrong password.
Related issue/s
How to test
cd services/web/server make install-dev pytest -vv --pdb tests/unit/isolated/test_login_rest_exceptions.py🗃️ Database
The
vendorcolumn in theproductstable now supports amarketing_fallback_products_on_wrong_passwordfield: a list of product names suggested to the user when they enter an incorrect password, guiding them toward the product where their account may have been merged.Example of
vendorcolumn content:{ "marketing_fallback_products_on_wrong_password": ["s4l", "s4lacad"] }🎤 Q&A
boolinstead of a list?A: It's more flexible and I avoid to hardcode product names (pre-existing in the target deployment) in the codebase.
Dev-ops
No changes.