Skip to content

🐛 [Frontend] Fix: Select searched folder#9032

Merged
odeimaiz merged 5 commits intoITISFoundation:masterfrom
odeimaiz:fix/searched-folder
Apr 15, 2026
Merged

🐛 [Frontend] Fix: Select searched folder#9032
odeimaiz merged 5 commits intoITISFoundation:masterfrom
odeimaiz:fix/searched-folder

Conversation

@odeimaiz
Copy link
Copy Markdown
Member

@odeimaiz odeimaiz commented Apr 15, 2026

What do these changes do?

reported by @matusdrobuliak66

Fixes folder selection when clicking a folder from search results by ensuring the target workspace context is carried along with the selection event, allowing the Study Browser to switch to the correct workspace before selecting the folder.

Bug:
SearchFolderBug

Fixed:
SearchFolderFix

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Etna milestone Apr 15, 2026
@odeimaiz odeimaiz self-assigned this Apr 15, 2026
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 15, 2026
@odeimaiz odeimaiz marked this pull request as ready for review April 15, 2026 12:19
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes folder selection when clicking a folder from search results by ensuring the target workspace context is carried along with the selection event, allowing the Study Browser to switch to the correct workspace before selecting the folder.

Changes:

  • Change the folderSelected event payload to include both workspaceId and folderId.
  • Update ResourceBrowserBase to forward the new payload shape to _folderSelected(workspaceId, folderId).
  • Update StudyBrowser’s _folderSelected implementation to use the provided workspaceId when changing context.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js Updates folder-selection handler to change context using the selected folder’s workspace.
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js Adjusts folderSelected listener and abstract method signature to accept workspaceId + folderId.
services/static-webserver/client/source/class/osparc/dashboard/FolderButtonItem.js Emits folderSelected with { workspaceId, folderId } to support correct navigation from search.

@odeimaiz odeimaiz merged commit b2b9e3e into ITISFoundation:master Apr 15, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants