🐛 fix(web-server): use X-Forwarded-Proto header for confirmation link scheme 🚑#9026
Merged
giancarloromeo merged 3 commits intoITISFoundation:masterfrom Apr 14, 2026
Conversation
giancarloromeo
added
the
a:webserver
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9026 +/- ##
==========================================
- Coverage 83.34% 82.90% -0.45%
==========================================
Files 1633 791 -842
Lines 63445 36833 -26612
Branches 927 176 -751
==========================================
- Hits 52878 30535 -22343
+ Misses 10332 6248 -4084
+ Partials 235 50 -185
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2 tasks
giancarloromeo
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
giancarloromeo
changed the title
X-Forwarded-Proto header for confirmation link schemeX-Forwarded-Proto header for confirmation link scheme 🚑
GitHK
approved these changes
Apr 14, 2026
pcrespov
approved these changes
Apr 14, 2026
bisgaard-itis
approved these changes
Apr 14, 2026
matusdrobuliak66
approved these changes
Apr 14, 2026
|
giancarloromeo
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request updates the confirmation link generation logic to correctly respect the
X-Forwarded-Protoheader, which is important when the service is running behind a proxy (like Traefik).Important
Confirmation links were composed using the
request.schemeand apparently they were removed in some emails.Related issue/s
How to test
cd services/web/server make install-dev pytest -vv --pdb tests/unit/with_dbs/03/login/test_login_confirmation_service.pyDev-ops
No changes.