🐛 Fixes e2e-playwright jupyterlab-large-file test#9022
🐛 Fixes e2e-playwright jupyterlab-large-file test#9022mergify[bot] merged 10 commits intoITISFoundation:masterfrom
Conversation
GitHK
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9022 +/- ##
==========================================
- Coverage 87.38% 87.36% -0.02%
==========================================
Files 2054 2054
Lines 80712 80712
Branches 1443 1443
==========================================
- Hits 70529 70518 -11
- Misses 9774 9785 +11
Partials 409 409
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Playwright E2E JupyterLab “large file” scenario to handle modal dialogs that can appear when editing/creating large files, and refactors the notebook-side workload to reduce runtime variance while increasing timeouts where needed.
Changes:
- Added dialog-dismissal logic and switched cell completion waiting to a polling loop that can dismiss dialogs mid-execution.
- Simplified the notebook workload to create a single large file, move only small files, and tightened the listing consistency check.
- Updated per-phase timeouts to better match the new workload and large-file behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/e2e-playwright/tests/jupyterlabs/helpers_jupyter_code.py |
Adds modal dialog dismissal and polling-based waiting for notebook phase completion markers. |
tests/e2e-playwright/tests/jupyterlabs/_jupyter_cell_code.py |
Refactors the generated workload phases (1 large file, move small files) and adjusts timeouts and listing checks. |
GitHK
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adjusts the e2e-playwright JupyterLab “large file” flow to be more resilient by dismissing modal dialogs that appear during notebook execution, and refactors the notebook-injected workload to run faster/more reliably.
Changes:
- Added dialog dismissal logic around cell execution to handle JupyterLab “file changed” (and similar) pop-ups.
- Refactored the Jupyter cell workload to create a single large file and to move only small files.
- Increased per-phase timeouts to better match observed runtimes in CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/e2e-playwright/tests/jupyterlabs/helpers_jupyter_code.py |
Adds polling-based expect wrapper that periodically dismisses blocking JupyterLab dialogs. |
tests/e2e-playwright/tests/jupyterlabs/_jupyter_cell_code.py |
Simplifies phases (1 large file; move small files) and updates phase timeouts. |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Playwright E2E JupyterLab “large file” scenario to reduce flakiness when JupyterLab shows a “file changed” modal dialog during notebook execution, and it rebalances the workload/timeouts used by the in-notebook workload phases.
Changes:
- Added modal-dialog dismissal logic and a polling
expectwrapper to keep execution progressing when dialogs appear. - Reduced the “large files” phase from multiple large files to a single large file and changed the move phase to only move small files.
- Increased per-phase timeouts in the in-notebook phase list to better match observed runtimes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/e2e-playwright/tests/jupyterlabs/helpers_jupyter_code.py |
Adds dialog dismissal + polling wait logic around output completion detection. |
tests/e2e-playwright/tests/jupyterlabs/_jupyter_cell_code.py |
Simplifies workload phases (1 large file, move small files) and updates phase timeouts. |
|
There was a problem hiding this comment.
Pull request overview
This PR updates the JupyterLab large-file Playwright E2E scenario to be more robust when JupyterLab shows a “file changed” (or similar) modal dialog during notebook execution, and adjusts the workload/timeouts to better match observed CI runtimes.
Changes:
- Add a polling-based “wait for marker” helper that periodically dismisses blocking JupyterLab dialogs while waiting for cell completion.
- Reduce large-file creation from multiple parallel files to a single large file and move only small files to speed up the workflow.
- Increase per-phase timeouts in the Jupyter-injected phase runner script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/e2e-playwright/tests/jupyterlabs/helpers_jupyter_code.py |
Adds dialog-dismiss logic and a polling expect wrapper to keep notebook execution unblocked. |
tests/e2e-playwright/tests/jupyterlabs/_jupyter_cell_code.py |
Simplifies the “large file” phase and changes file-moving behavior; updates phase timeouts. |
|
@Mergifyio queue |
Merge Queue Status🛑 Queue command has been cancelled |
Merge Queue Status
This pull request spent 18 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
What do these changes do?
Adjusted the
e2e-playwright -> jupyterlab-large-filetest.Related issue/s
How to test
Dev-ops