EAP: Bugs and feedback changes 2#2312
Merged
frozenhelium merged 2 commits intoApr 17, 2026
Merged
Conversation
|
shreeyash07
force-pushed
the
fix/eap-feedback-changes-2
branch
3 times, most recently
from
6b6edf8 to
e3816b1
Compare
shreeyash07
changed the title
shreeyash07
requested review from
AdityaKhatri,
barshathakuri,
frozenhelium,
subinasr and
tnagorra
shreeyash07
force-pushed
the
fix/eap-feedback-changes-2
branch
from
5a2c2d7 to
e3bf2e5
Compare
frozenhelium
requested changes
Apr 16, 2026
| filters={!presentationMode && ( | ||
| <> | ||
| <DateInput | ||
| type="date" |
Member
There was a problem hiding this comment.
Let's make it default prop
| value={rawFilter.startDateAfter} | ||
| /> | ||
| <DateInput | ||
| type="date" |
Member
There was a problem hiding this comment.
Let's make it default prop
| filters={( | ||
| <> | ||
| <DateInput | ||
| type="date" |
Member
There was a problem hiding this comment.
Let's make it default prop
shreeyash07
force-pushed
the
fix/eap-feedback-changes-2
branch
from
e3bf2e5 to
68c9d75
Compare
frozenhelium
approved these changes
Apr 17, 2026
- add partners field in both eap forms
- pass type props in every DateInput field
- remove year option in timeFrame for readiness and prepositioning activities
- make ap code form fields view only
- update in translation strings
- add missing validation for plannedOperations and enablingApproaches form fields
- add eap apCode options for both forms
- improve eap table action flow
- add revise button for creating new version
- add additional attachments modal in EAP table
- make lead_timeframe_unit and lead_time field required
- replace diff library to diff-match-patch
- new DiffTextOutput components
- update PrintableDescription and PrintableLabel components
- add utility function for expected_submission_time field
frozenhelium
force-pushed
the
fix/eap-feedback-changes-2
branch
from
91a1eb7 to
cc154e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends On
Changes
activities
This PR Ensures:
console.logstatements meant for debugging