Skip to content

Add web app serve for alpha deployment#241

Open
barshathakuri wants to merge 1 commit into
developfrom
feature/web-app-serve
Open

Add web app serve for alpha deployment#241
barshathakuri wants to merge 1 commit into
developfrom
feature/web-app-serve

Conversation

@barshathakuri
Copy link
Copy Markdown
Contributor

@barshathakuri barshathakuri commented Dec 4, 2025

Summary

Add web app serve

Addresses

Depends On

  • Other PRs or Dependencies: List PRs or dependencies this PR relies on.

Changes

  • Integrate web app serve

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No console.log statements meant for debugging
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • pnpm lint runs without errors
  • pnpm typecheck passes (no type errors)
  • pnpm knip passes
  • pnpm build completes successfully

Additional Notes

Optional: Add any other relevant context, screenshots, or details here.

Comment thread .dockerignore
@@ -1,143 +1,4 @@
# Swap files
*.swp
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are not required in dockerignore.

Comment thread Dockerfile
ENV APP_HCAPTCHA_SITEKEY=APP_HCAPTCHA_SITEKEY_PLACEHOLDER
ENV APP_TITLE=Alerthub
ENV APP_ENVIRONMENT=production
ENV APP_MAPBOX_ACCESS_TOKEN=WEB_APP_SERVE_PLACEHOLDER__APP_MAPBOX_ACCESS_TOKEN
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this, use a dummy data or leave it empty.
We only need to do this to variables that are used outside of the application itself.

submodules: true

- name: Publish web-app-serve
uses: toggle-corp/web-app-serve-action@v0.1.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it 0.1.1 or 0.1.2?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.1 it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants