Skip to content

Introduce life-cycle methods to App#13099

Merged
fniessink merged 1 commit intomasterfrom
13098-use-lifecycle-methods
May 3, 2026
Merged

Introduce life-cycle methods to App#13099
fniessink merged 1 commit intomasterfrom
13098-use-lifecycle-methods

Conversation

@fniessink
Copy link
Copy Markdown
Member

  • Move reload after status update to componentDidUpdate
  • Move history.listen/unlisten to componentDidMount/componentWillUnmount
  • Increase test coverage

@fniessink fniessink linked an issue May 3, 2026 that may be closed by this pull request
- Move reload after status update to componentDidUpdate
- Move history.listen/unlisten to componentDidMount/componentWillUnmount
- Increase test coverage
@fniessink fniessink force-pushed the 13098-use-lifecycle-methods branch from 851d4d5 to 92f8077 Compare May 3, 2026 11:35
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
85.0% Coverage on New Code (required ≥ 100%)
78.6% Line Coverage on New Code (required ≥ 100%)

See analysis details on SonarQube Cloud

@fniessink fniessink merged commit c7e70d4 into master May 3, 2026
36 of 37 checks passed
@fniessink fniessink deleted the 13098-use-lifecycle-methods branch May 3, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use lifecycle methods

1 participant