fix: enable React app cookie authentication for API endpoints#4782
Draft
gcgoncalves wants to merge 1 commit into
Draft
fix: enable React app cookie authentication for API endpoints#4782gcgoncalves wants to merge 1 commit into
gcgoncalves wants to merge 1 commit into
Conversation
🔗 Issue Relates to #4269 🚀 Summary Fixed 401 Unauthorized errors when React app accesses API endpoints (e.g., /teams/) using cookie authentication. Modified RBAC middleware to recognize X-Requested-With: XMLHttpRequest header as valid first-party signal, and changed JWT/CSRF cookie paths from /app to / to allow cookies to be sent to root-level API endpoints. 📓 Notes - RBAC middleware now accepts X-Requested-With header + /app referer as proof of first-party origin - JWT cookie path changed from /app to / (mcpgateway/routers/app.py:40) - CSRF cookie path changed from /app to / (mcpgateway/utils/csrf.py:64) - Cookie path scoping to /app was overly restrictive given React app needs to call root-level APIs - X-Requested-With recognition is the primary security improvement; cookie path change enables functionality Signed-off-by: Gabriel Costa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue
Relates to #4269
🚀 Summary
Fixed 401 Unauthorized errors when React app accesses API endpoints (e.g., /teams/) using cookie authentication. Modified RBAC middleware to recognize X-Requested-With: XMLHttpRequest header as valid first-party signal, and changed JWT/CSRF cookie paths from /app to / to allow cookies to be sent to root-level API endpoints.
📓 Notes