fix(password): align validation feedback and show correct policy requirements#4778
Open
rakdutta wants to merge 5 commits into
Open
fix(password): align validation feedback and show correct policy requirements#4778rakdutta wants to merge 5 commits into
rakdutta wants to merge 5 commits into
Conversation
…plexity) on validation failure Signed-off-by: Rakhi Dutta <[email protected]>
…change page Signed-off-by: Rakhi Dutta <[email protected]>
Signed-off-by: Rakhi Dutta <[email protected]>
Signed-off-by: Rakhi Dutta <[email protected]>
The doctest in validate_password_detailed() was not executable due to SessionLocal initialization requirements. Unit tests provide comprehensive coverage of this method's behavior. Coverage for password_policy_service.py now at 97% (well above 93% threshold). Co-Authored-By: Claude Haiku 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4753
Summary
Centralizes password policy requirements and standardizes validation feedback across user
creation and password change flows. Users now receive consistent, explicit policy guidance
(12 characters minimum, 3-of-4 complexity groups) both during form entry and on validation failure.
Changes
Unified Policy Requirements
get_password_requirements()static method inPasswordPolicyServiceexposing a complete,descriptive set of password rules (minimum length, complexity rules, restrictions) for use by both backend
and frontend
password_requirementsdictionary instead of individual policy flags,ensuring the frontend always receives up-to-date requirements
Enhanced Error Handling
Frontend User Experience
Configuration & Maintenance
.env.exampleto document password length environment variables for different account types (following OWASP recommendations)