Skip to content

Added alembic history branches check#4703

Open
cafalchio wants to merge 2 commits into
mainfrom
task/workflow_to_validate_alembic_migration
Open

Added alembic history branches check#4703
cafalchio wants to merge 2 commits into
mainfrom
task/workflow_to_validate_alembic_migration

Conversation

@cafalchio
Copy link
Copy Markdown
Collaborator

@cafalchio cafalchio commented May 11, 2026

🔗 Related Issue

Closes #4648

This PR cannot be merged before #4690


📝 Summary

This PR adds a check on the workflow to validate that alembic history is linear and no branches were created.

This check is to avoid DB migration issues in the future.


🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)

🧪 Verification

Check Command Status
Lint suite make lint x
Unit tests make test x
Coverage ≥ 80% make coverage x

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • Tests added/updated for changes
  • Documentation updated (if applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Screenshots, design decisions, or additional context.

@cafalchio cafalchio marked this pull request as ready for review May 11, 2026 13:53
@cafalchio cafalchio marked this pull request as draft May 11, 2026 13:53
@cafalchio cafalchio added the db Database and migrations label May 13, 2026
@cafalchio cafalchio added this to the Release 1.2.0 milestone May 13, 2026
@cafalchio cafalchio marked this pull request as ready for review May 13, 2026 15:47
cafalchio added 2 commits May 18, 2026 09:35
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
@cafalchio cafalchio force-pushed the task/workflow_to_validate_alembic_migration branch from 8de6794 to 87730a3 Compare May 18, 2026 08:49
Comment thread scripts/ci/run_upgrade_validation.sh
Copy link
Copy Markdown
Collaborator

@madhu-mohan-jaishankar madhu-mohan-jaishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a screenshot of this running?

@cafalchio
Copy link
Copy Markdown
Collaborator Author

Here is a screenshot of the test running locally

Passing (linear history)

Screenshot From 2026-05-18 11-04-34

Failing (branches)

Screenshot From 2026-05-18 11-03-13

@cafalchio
Copy link
Copy Markdown
Collaborator Author

Added more information
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

db Database and migrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE]: Add CI workflow to validate Alembic migration history is linear

2 participants