Skip to content

correct plural forms for week and millisecond in relative date phrases #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigmade wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −5
Open

correct plural forms for week and millisecond in relative date phrases #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
134c20f
correct plural forms for week and millisecond in relative date phrases
Apr 19, 2026
6ea2a21
correct tests
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/Humanizer/Locales/ru.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ surfaces:
millisecond:
single: 'миллисекунду назад'
multiple:
forms: 'миллисекунд'
forms:
default: 'миллисекунд'
singular: 'миллисекунду'
dual: 'миллисекунды'
afterCount: 'назад'
Comment on lines 29 to 34
second:
single: 'секунду назад'
Expand Down Expand Up @@ -67,7 +70,10 @@ surfaces:
week:
single: 'неделю назад'
multiple:
forms: 'недель'
forms:
default: 'недель'
singular: 'неделю'
dual: 'недели'
afterCount: 'назад'
month:
single: 'месяц назад'
Expand All @@ -89,7 +95,10 @@ surfaces:
millisecond:
single: 'через миллисекунду'
multiple:
forms: 'миллисекунд'
forms:
default: 'миллисекунд'
singular: 'миллисекунду'
dual: 'миллисекунды'
beforeCount: 'через'
second:
single: 'через секунду'
Expand Down Expand Up @@ -129,7 +138,10 @@ surfaces:
week:
single: 'через неделю'
multiple:
forms: 'недель'
forms:
default: 'недель'
singular: 'неделю'
dual: 'недели'
beforeCount: 'через'
month:
single: 'через месяц'
Expand Down
2 changes: 1 addition & 1 deletion ...manizer.Tests/Localisation/GeneratedLocaleData/GeneratedLocaleDeRuPhraseMigrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void RussianPhraseTableUsesCompactGrammarAwareYamlForms()

Assert.True(table.TryGetDatePhrase(TimeUnit.Week, Tense.Future, out var futureWeek));
Assert.Equal("недель", futureWeek.Multiple?.Forms.Default);
Assert.Null(futureWeek.Multiple?.Forms.Dual);
Assert.Equal("недели", futureWeek.Multiple?.Forms.Dual);
}

[Theory]
Expand Down
Loading