Fix ByteSize implementation in regards to IEC specification#1413
Open
CollinAlpert wants to merge 5 commits intoHumanizr:mainfrom
Open
Fix ByteSize implementation in regards to IEC specification#1413CollinAlpert wants to merge 5 commits intoHumanizr:mainfrom
CollinAlpert wants to merge 5 commits intoHumanizr:mainfrom
Conversation
# Conflicts: # src/Humanizer/Localisation/DataUnit.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is targeted for the v3 release, since it contains a breaking change in how the
ByteSizecalculates sizes.Until now, one kilobyte is considered to be 1024 bytes, which is incorrect. The code
Console.WriteLine(ByteSize.FromMegabytes(1).Bytes);prints1048576instead of1000000which was initially very surprising to me. I have had countless discussions over this surprising behavior with my teammates.This PR fixes the calculation and adds methods to aid in calculating binary instead of decimal powers.