Skip to content

Add env_name to each FastlaneCore::ConfigItem#120

Open
liamnichols wants to merge 1 commit intoHazAT:masterfrom
liamnichols:ln/env-names
Open

Add env_name to each FastlaneCore::ConfigItem#120
liamnichols wants to merge 1 commit intoHazAT:masterfrom
liamnichols:ln/env-names

Conversation

@liamnichols
Copy link
Copy Markdown

@liamnichols liamnichols commented Jan 18, 2024

Hello @HazAT 👋

We've been using this action for a while and it's been doing a great job! I was recently doing some refactoring however and I want to cleanup some of our fastfiles by doing the following:

- add_badge(shield: "#{title}-#{value}-blue", dark: true, no_badge: true)
+ add_badge(shield: "#{title}-#{value}-blue")

I've done this in a lot of other places by defining our default parameters in a .env file, however I found that we couldn't do it with this action because it doesn't define the env_name on the available options so this PR aims to address that 🙏

It should be a relatively small change all things considered 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant