Conversation
kriszyp
force-pushed
the
test/fix-cache-assertions
branch
from
a278103 to
e435b15
Compare
heskew
approved these changes
Mar 19, 2026
cb1kenobi
reviewed
Mar 19, 2026
| results.push(record); | ||
| } | ||
| assert.equal(results.length, 1); | ||
| assert.equal(sourceRequests, 2); |
Contributor
There was a problem hiding this comment.
PR #250 attempts to fix the underlying problem that was causing this test to fail. By moving this assertion before the second get(), you're just making the test pass. No?
Member
Author
There was a problem hiding this comment.
The intent of this test is verify that the accessing expired records through a query (that uses a secondary index) will trigger a load from source/origin. I think with timing, sometimes the record may expire again before the subsequent call to IndexedCachingTable.get(23), triggering a third source request, which is fine, we aren't really trying to verify that the subsequent get won't go to source, just that it works and is correct.
DavidCockerill
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, with 15% less flakiness 🤞