Skip to content

Exclude CI/dev files from built gem and update homepage#19

Open
ahaverbuch wants to merge 5 commits intomasterfrom
exclude-ci-files-from-gem
Open

Exclude CI/dev files from built gem and update homepage#19
ahaverbuch wants to merge 5 commits intomasterfrom
exclude-ci-files-from-gem

Conversation

@ahaverbuch
Copy link
Copy Markdown

Summary

  • Filter .buildkite/pipeline.yml, Dockerfile, docker-compose.yml, and solano.yml out of spec.files so they don't ship in the published gem
  • Update spec.homepage to point at the current repo (gusto/fixy) instead of the original chetane/fixy

Test plan

  • gem build fixy.gemspec and inspect the resulting .gem to confirm excluded files are absent and lib/, README, CHANGELOG, LICENSE, Rakefile, Gemfile remain

Comment thread fixy.gemspec Outdated
Comment thread fixy.gemspec
spec.version = Fixy::VERSION
spec.authors = ['Omar Skalli']
spec.email = ['omar@zenpayroll.com']
spec.authors = ['Gusto']
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as it's current/more accurate about who and how to contact about this fork, but I would suggest moving info about the Fork into either the Description or Summary.

Alternatively, since it's an array, you could use both entries

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Omar isn't here anymore so this gives more accurate

Comment thread fixy.gemspec Outdated
Co-authored-by: Dave Corson-Knowles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants