Skip to content

Fix 'Jitter Points' and 'Sample Polylines' working incorrectly with X or Y scale of 0 content#3984

Open
Keavon wants to merge 4 commits intomasterfrom
fix-zero-scale-node-issues
Open

Fix 'Jitter Points' and 'Sample Polylines' working incorrectly with X or Y scale of 0 content#3984
Keavon wants to merge 4 commits intomasterfrom
fix-zero-scale-node-issues

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 1, 2026

Fixes #2790.

Also closes #3897 since it's a one-liner.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the robustness of vector operations when dealing with singular transforms (zero scale). Key changes include refactoring polyline sampling to compute locations in world space while evaluating them on untransformed paths, and updating the jitter points logic to handle zero-determinant matrices. Feedback suggests refining the matrix repair logic in the jitter points function to better handle collinear vectors, ensuring that scaling along the collapsed axis is not ignored. Additionally, the Monitor and Extract nodes have been moved out of the Debug category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when adding an Extract node in the node editor Jitter Points node has unexpected behaviour

1 participant