Skip to content

Add the "Along Normals" parameter to the 'Jitter Points' node#3983

Merged
Keavon merged 2 commits intomasterfrom
jitter-along-normals
Apr 1, 2026
Merged

Add the "Along Normals" parameter to the 'Jitter Points' node#3983
Keavon merged 2 commits intomasterfrom
jitter-along-normals

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 1, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an 'Along Normals' parameter to the 'Jitter Points' node, allowing points to be offset perpendicular to the path direction. The implementation includes new tangent calculation methods in SegmentDomain and a document migration for existing nodes. Review feedback suggests replacing the magic number 1e3 used for epsilon scaling with a named constant to improve maintainability.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Confidence score: 3/5

  • There is a concrete behavior bug: self-loop segments are counted once, so point_tangent returns an incorrect single-connection tangent for looped segments in node-graph/libraries/vector-types/src/vector/vector_attributes.rs.
  • This is a medium-severity, user-visible geometry correctness issue, so it carries some risk despite being localized.
  • Pay close attention to node-graph/libraries/vector-types/src/vector/vector_attributes.rs - verify handling of self-loop segment tangents.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/libraries/vector-types/src/vector/vector_attributes.rs">

<violation number="1" location="node-graph/libraries/vector-types/src/vector/vector_attributes.rs:475">
P2: Self-loop segments (start == end) are only counted once here, so point_tangent returns a single-connection tangent instead of treating the segment as two connections. That yields the wrong tangent for looped segments.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) April 1, 2026 10:06 Inactive
@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) April 1, 2026 12:17 Inactive
@Keavon Keavon merged commit 211b911 into master Apr 1, 2026
11 checks passed
@Keavon Keavon deleted the jitter-along-normals branch April 1, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant