Add the "Along Normals" parameter to the 'Jitter Points' node#3983
Merged
Add the "Along Normals" parameter to the 'Jitter Points' node#3983
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an 'Along Normals' parameter to the 'Jitter Points' node, allowing points to be offset perpendicular to the path direction. The implementation includes new tangent calculation methods in SegmentDomain and a document migration for existing nodes. Review feedback suggests replacing the magic number 1e3 used for epsilon scaling with a named constant to improve maintainability.
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 3/5
- There is a concrete behavior bug: self-loop segments are counted once, so
point_tangentreturns an incorrect single-connection tangent for looped segments innode-graph/libraries/vector-types/src/vector/vector_attributes.rs. - This is a medium-severity, user-visible geometry correctness issue, so it carries some risk despite being localized.
- Pay close attention to
node-graph/libraries/vector-types/src/vector/vector_attributes.rs- verify handling of self-loop segment tangents.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/libraries/vector-types/src/vector/vector_attributes.rs">
<violation number="1" location="node-graph/libraries/vector-types/src/vector/vector_attributes.rs:475">
P2: Self-loop segments (start == end) are only counted once here, so point_tangent returns a single-connection tangent instead of treating the segment as two connections. That yields the wrong tangent for looped segments.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
node-graph/libraries/vector-types/src/vector/vector_attributes.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.