Skip to content

Add Layers panel support for displaying multiple groups with instances of the same children layers#3982

Merged
Keavon merged 2 commits intomasterfrom
layers-panel-multi-instance-children
Apr 1, 2026
Merged

Add Layers panel support for displaying multiple groups with instances of the same children layers#3982
Keavon merged 2 commits intomasterfrom
layers-panel-multi-instance-children

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 1, 2026

Closes #2153

image

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the layer panel to support layer instances by using instance paths (sequences of node IDs) instead of single node IDs. This allows the same layer to appear in multiple locations within the hierarchy while maintaining independent expansion states. Key changes include a rewritten graph traversal for building the layer structure, updated serialization for backward compatibility, and frontend adjustments to handle path-based expansion and selection. A suggestion was made to use a more idiomatic filtering approach when extending the list of collapsed layers during recursive operations.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) April 1, 2026 06:39 Inactive
@github-actions github-actions bot temporarily deployed to graphite-dev (Preview) April 1, 2026 07:11 Inactive
@Keavon Keavon merged commit d41883a into master Apr 1, 2026
10 checks passed
@Keavon Keavon deleted the layers-panel-multi-instance-children branch April 1, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Layers panel doesn't show expandable children for the lower layer, only the top layer

1 participant