Auto-generate enum type widget boilerplate for radio buttons and dropdown menus#2589
Merged
Keavon merged 23 commits intoGraphiteEditor:masterfrom May 1, 2025
Merged
Conversation
Keavon
force-pushed
the
rfc-dropdowns-refactor
branch
from
1512c4a to
d571abf
Compare
Keavon
changed the title
Keavon
approved these changes
May 1, 2025
Member
|
The macro code looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Mostly) resolves #2587. This refactors the UI for dropdowns and radio buttons based on built-in enums.
Dropdowns and radio buttons associated with node sockets can be produced via a builder API, with this API in turn getting its data from a proc macro that operates on enums. The particular shape should facilitate extending this to user-defined enums, to values that are not associated with a socket, and to menu entries (eg, the ones to add a boolean operation).