Restore auto-panning that #2443 had broken#2562
Restore auto-panning that #2443 had broken#2562Keavon merged 5 commits intoGraphiteEditor:masterfrom
Conversation
| for message in editor.handle_message(BroadcastMessage::TriggerEvent(BroadcastEvent::AnimationFrame)) { | ||
| handle.send_frontend_message_to_js(message); | ||
| } |
There was a problem hiding this comment.
I think it would be better to dispatch both the broadcast event and the increment frame counter message from the CurrentTime input preprocessor message handler. Having these multiple invocations is not pretty. It also somewhat obfuscates that setting the current time now has a side effect (of changing the frame time).
I'm also wondering if it even makes sense to use the animation frame here at all for non render related editor timing. We could consider adding a LogicTick broadcast event which is triggered on a set interval timer and seperate this completely from animation related functionality
There was a problem hiding this comment.
I'm also wondering if it even makes sense to use the animation frame here at all for non render related editor timing. We could consider adding a LogicTick broadcast event which is triggered on a set interval timer and seperate this completely from animation related functionality
(To be clear, that would be a separate discussion for a later PR, this one is just focused on un-breaking the functionality without refactoring or rearchitecting it.)
There was a problem hiding this comment.
I mean the code should work, I just don't like it, but I didn't like it before either so that is not a merge blocker
|
!build |
|
Keavon
changed the title
3 participants
Fixes #2504 by restoring part of the code deleted in #2443