Fix: Remove hardcoded temperature overrides to use provider defaults#438
Open
DanielRyanSmith wants to merge 1 commit intomainfrom
Open
Fix: Remove hardcoded temperature overrides to use provider defaults#438DanielRyanSmith wants to merge 1 commit intomainfrom
DanielRyanSmith wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
This was an even smaller change than I had initially anticipated 😅 See the issue for rationale, but mainly this line from the Gemini 3 documentation: "For all Gemini 3 models, we strongly recommend keeping the temperature parameter at its default value of 1.0. "While previous models often benefited from tuning temperature to control creativity versus determinism, Gemini 3's reasoning capabilities are optimized for the default setting. Changing the temperature (setting it below 1.0) may lead to unexpected behavior, such as looping or degraded performance, particularly in complex mathematical or reasoning tasks." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #437
Overview
Removes the hardcoded
0.01temperature overrides from the Requirements Extraction and Coverage Audit phases, allowing them to fall back to the provider's default model temperature.Root Cause / Motivation
Previously, the
requirements_extractionandcoverage_auditphases explicitly hardcoded their temperature to0.01when making LLM requests. This prevented the LLM's default temperature from being used and ignored the tool's intended fallback mechanism where no override allows the default to be respected.Detailed Changelog
wptgen/phases/requirements_extraction.py: Removed thetemperaturekeyword argument when callinggenerate_safe, allowing the API client to use the provider's default temperature.wptgen/phases/coverage_audit.py: Removed thetemperaturekeyword argument when callinggenerate_safe, allowing the API client to use the provider's default temperature.