style: align tests/ directory with Google Style Guide (#415)#432
Merged
style: align tests/ directory with Google Style Guide (#415)#432
Conversation
becaeb2 to
a54b6a1
Compare
a54b6a1 to
e172434
Compare
ca10c43 to
f274043
Compare
Collaborator
DanielRyanSmith
left a comment
There was a problem hiding this comment.
One request, but otherwise this is almost ready. 🙂
DanielRyanSmith
requested changes
Apr 13, 2026
szy196
added a commit
that referenced
this pull request
Apr 13, 2026
7d9cafd to
beae77f
Compare
DanielRyanSmith
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background & Motivation
This PR aligns the
tests/directory with the Google Style Guide and project-specific linting standards. It ensures that the test suite is maintainable, readable, and follows consistent patterns across all modules.Proposed Changes
tests/.pylintrcto align with the root config (80-character limit, Google Style rules) while maintaining necessary pytest-specific overrides (redefined-outer-name,unused-argument).tests/directory.if not sequence:) as per the style guide.# pylint: disable=line-too-longfor 40 instances where wrapping was impractical (primarily long mock data strings).tests/test_chromestatus.pywhich had incorrect mocks for network calls, causing flakyTimeoutErrorin some environments.make lint-fix(pyink) to ensure consistent formatting across all modified files.tests/directory with the updated strict configuration.Related Issues
Resolves #415
Follow-up issue created: #431 (to refactor
test_phases.pyinto smaller modules).Acceptance Criteria
pylintwith the new configuration.make presubmitruns cleanly for the entire repository.This PR description was drafted by Gemini