This repository was archived by the owner on Mar 14, 2024. It is now read-only.
[Text fragments article] Rename textStart→start and textEnd→end#9815
Merged
[Text fragments article] Rename textStart→start and textEnd→end#9815
textStart→start and textEnd→end#9815Conversation
✅ Deploy Preview for web-dev-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rachelandrew
approved these changes
Mar 27, 2023
Collaborator
rachelandrew
left a comment
rachelandrew
left a comment
There was a problem hiding this comment.
We should move this to d.c.c.
Member
Author
It's supported by Chrome and Safari and Firefox is positive on it. |
Collaborator
|
it's just had a spec change though? |
Member
Author
|
This is purely a housekeeping renaming. It's not web exposed (see GoogleChromeLabs/text-fragments-polyfill#148 (comment)) for one tiny bit of non-defined exposition. |
1 similar comment
Member
Author
|
This is purely a housekeeping renaming. It's not web exposed (see GoogleChromeLabs/text-fragments-polyfill#148 (comment)) for one tiny bit of non-defined exposition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
textStart→startandtextEnd→end(see Rename textStart and textEnd WICG/scroll-to-text-fragment#218).