Yaakobiben/feature/dispatch event

[evincedbenyaakobi]

Description

Including:

1. this fix
2. these rules
3. changed default rules repo to be ours instead of the original
4. add session storage per tab in background
5. reset tab's storage session on every tab reload
6. send (once) event of finishing(error, handled or nothing) through all windows hierarchy(in case we are in iframes).
7. Fixed an additional bug: cookie popup -> get rid of cookie popup -> HandledCMP -> Nothing -> Nothing. I fixed it so it would emit one event(HandledCMP) with finite events(HandledCMP, Error) taking precedence. |
8. Removed wait when an HandledCMP event is emitted(since it can be in an iframe and then it is discarded and waits for nothing)

Tests

1. Tested on https://sky.it - iframe
2. Tested on https://business.sky.com/wholesale - iframe
3. Tested on https://www.natwestgroup.com/

In all tests I used this to test:

window.addEventListener("message", function(event) {
  if (event.data.type === "FROM_EXTENSION") {
    console.log("Message from extension:", JSON.stringify(event.data));
  }
});

I encountered new sessions through each iframe so I had to modify the code to adapt. In that way, I send whether the event is in an iframe and what is the iframe location.

[AdamKanari]

You are posting to all the chain?

[evincedbenyaakobi]

yes. I don't know how deep in iframes I am

[AdamKanari]

But can we just post the message on the last window who's parent is null?

[evincedbenyaakobi]

we can(not null, but the window itself: window.parent === window), but it's safer to post on all windows