Fix slot export for HF NTAG 216 tags#823
Open
vidonnus wants to merge 1 commit intoGameTec-live:mainfrom
Open
Conversation
Owner
|
Ok, so how much of this is AI and did you review the code? Maybe just disclose this at the end of the PR or something as projects that dont take AI code will figure it out anyways and the ones that do or dont care will appreciate the transparency. |
Author
100%, yes, and will do. |
Owner
|
Hey, finally had time to test, but I cant reproduce the issue you are describing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Clicking the download button in slot settings for an HF NTAG 216 slot silently fails — neither "Save to file", "Export to new card", nor "Update saved card" produce any result. This is caused by an unhandled exception during the 231 sequential page reads required for NTAG 216, which Flutter silently swallows, leaving the UI unresponsive with no feedback.
Issue: N/A
Changes
Breaking Changes
None