Fix issue with saltwater in remap_lake_landice_salt#144
Merged
Conversation
mathomp4
added
the
0 diff
weiyuan-jiang
previously approved these changes
Jun 12, 2025
sdrabenh
approved these changes
Jun 25, 2025
gmao-rreichle
added a commit
to GEOS-ESM/GEOSldas
that referenced
this pull request
Jun 30, 2025
v2.1.9 fixes issue with saltwater in remap_lake_landice_salt (GEOS-ESM/GEOS_Util#144)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in remap_restarts. A bit of code was left that had a variable
saltwaterthat is no longer around after #125.This should fix it.
I'll let @weiyuan-jiang take a look.