You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your contribution! Please excuse my late response.
I do not quite understand your conditions in rectInteresects. For example in line 89: why do you add 1 on the left side of the comparison? Why is it not just rt1.x1 > rt1.x2?
Also I find the code quite difficult to understand, since you first assign both l1 and r1 the same value and change one of them afterwards depending on the condition. I would find it easier to understand, if both variables were assigned after evaluating the condition.
If adding 1 (see above) is wrong in the end, the code would boil down to l1 = min(rt1.x1, rt1.x2); r1 = max(rt1.x1, rt1.x2);. But then also the potential swapping of .x1 and .x2 would never occur, because it is already guaranteed on the calling side that .x1 <= .x2.
Why is the function called rectIntersects and not, e.g., rectsIntersect? Since two rects are checked for intersection I would expect plural.
Last, but not least, please use tabs for indentation like in the rest of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2