Added CLI option to show line numbers for errors#43
Open
fkarg wants to merge 14 commits intoFindus23:masterfrom
Open
Added CLI option to show line numbers for errors#43fkarg wants to merge 14 commits intoFindus23:masterfrom
fkarg wants to merge 14 commits intoFindus23:masterfrom
Conversation
newlines sometimes though
Owner
|
Hi, This is the only of your changes I am not sure about if I should merge. I honestly never had the need to know the line number of the error (a search in the text editor shows it quickly most of the time) and with the MD/HTML/TeX/etc. conversion it wouldn't work in most cases anyway. I merged 328d3da and e859890, but if you are okay, I would just add a part in the documentation that mentions the existence of your code in case someone else is interested in this. |
Contributor
Author
|
Sure, sounds good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested/written for usage with Markdown.