Conversation
|
The Swift sample displays "Raster data copyright Scottish Government and SEPA (2014)" string on screen (and in the README). Do we need to display it on screen as well? |
gunt0001
left a comment
gunt0001
left a comment
There was a problem hiding this comment.
@rom14514 - nice work, a few comments. Note, I wasn't able to fully test the sample since my device does not support analysis. I was able to get a decent error dialog though, so at least I tested that part. The second reviewer will need to do the rest of the testing.
I believe showing this in the readme is sufficient. @shubham7109 - can you confirm? |
shubham7109
left a comment
shubham7109
left a comment
There was a problem hiding this comment.
@rom14514 Nice work! I've added some general review comments, and will confirm that we need to supply the copyright for this sample to be visible at all times when the data is used.
See portal item info:
If using this data you must acknowledge the source of the Information in your product or application by including or linking to any attribution statement specified by the Information Provider(s) and, where possible, provide a link to this licence;
# Conflicts: # gradle/libs.versions.toml
shubham7109
left a comment
shubham7109
left a comment
There was a problem hiding this comment.
@rom14514 Sample works well and code looks good. Apologies for missing on these doc comments previously, I have few change requests.
…mple/applymapalgebra/DownloadActivity.kt Co-authored-by: Shubham Sharma <[email protected]>
Co-authored-by: Shubham Sharma <[email protected]>
shubham7109
left a comment
shubham7109
left a comment
There was a problem hiding this comment.
Looks good to merge 👍
|
@gunt0001 @shubham7109 Thanks for reviews! Merging now |
3 participants
Description
PR to add a new Kotlin sample "Apply map algebra" in
Analysiscategory.Links and Data
Sample Epic:
runtime/kotlin/issues/7395What To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.