fix(metal): GDN bfloat16, PA scheduler, error handling, MLX SDPA fixes#2047
Open
emanueleDiVizio wants to merge 9 commits intoEricLBuehler:masterfrom
Open
fix(metal): GDN bfloat16, PA scheduler, error handling, MLX SDPA fixes#2047emanueleDiVizio wants to merge 9 commits intoEricLBuehler:masterfrom
emanueleDiVizio wants to merge 9 commits intoEricLBuehler:masterfrom
Conversation
…duler Reapply upstream fixes from PRs EricLBuehler#2031/EricLBuehler#2034: fix quadratic scheduling complexity when sequences are waiting, and add FCFS priority ordering to prevent starvation.
…l prefill Add an optional MLX SDPA backend using steel flash attention kernels for Metal prefill. Enable head_dim=256 support for models like Qwen3.5 that use larger attention head dimensions.
3bbe0a9 to
af3e7f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple correctness, performance, and stability issues encountered while running mistral.rs on Apple Silicon (M-series) with real multi-user inference workloads (Qwen3.5 MoE + Mixtral).
The changes focus on:
Several of these issues only surface under concurrent decode or long-running sessions.
Key changes
Scheduler (from upstream PRs #2031/#2034)
GDN / Metal
bfloatvsbfloat16_t) in Metal kernelsStability
Performance / Features
Test plan