Skip to content

sTest: add multislice tests#2729

Open
wsmoses wants to merge 2 commits intomainfrom
mst
Open

sTest: add multislice tests#2729
wsmoses wants to merge 2 commits intomainfrom
mst

Conversation

@wsmoses
Copy link
Copy Markdown
Member

@wsmoses wsmoses commented Mar 25, 2026

No description provided.

@wsmoses
Copy link
Copy Markdown
Member Author

wsmoses commented Mar 25, 2026

@copilot fix the tests

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

@copilot fix the tests

Fixed in 322dc0b:

  • Added sz truncation to multislice_both (consistent with other functions)
  • Fixed invalid begin...end in for testset syntax
  • Added outer @testset "MultiSlice" wrapper with if inside
  • Replaced contains checks with @filecheck (consistent with other tests)
  • Fixed regex patterns to include (-start)? variant
  • Fixed mixed tabs/spaces indentation
  • Added TPU skip warning matching MultiRotate pattern

x = collect(Int, 0:(size2 - 1))
rx = Reactant.to_rarray(x; sharding)

hlo = repr(@code_xla shardy_passes = :to_mhlo_shardings multislice_both(rx, size))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
hlo = repr(@code_xla shardy_passes = :to_mhlo_shardings multislice_both(rx, size))
hlo = repr(
@code_xla shardy_passes = :to_mhlo_shardings multislice_both(rx, size)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants