refactor(driver): move Flysky gimbal sync into board-level ADC callbacks#7263
Open
raphaelcoeffic wants to merge 1 commit intomainfrom
Open
refactor(driver): move Flysky gimbal sync into board-level ADC callbacks#7263raphaelcoeffic wants to merge 1 commit intomainfrom
raphaelcoeffic wants to merge 1 commit intomainfrom
Conversation
Flysky gimbal synchronization (HALL_SYNC GPIO for V1, command-based start_read/wait_completion for V2) was scattered across the HAL layer (adc_driver.cpp) and mixer task (mixer_task.cpp). This moves it into the board-level ADC callbacks in analog_inputs.cpp, matching the existing ADS79xx SPI ADC integration pattern. The gimbal driver now owns all its synchronization: GPIO init, HALL_SYNC assert/deassert, and V2 command sequencing. No hardware-specific code remains in hal/ or tasks/. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flysky gimbal synchronization (HALL_SYNC GPIO for V1, command-based start_read/wait_completion for V2) was scattered across the HAL layer (adc_driver.cpp) and mixer task (mixer_task.cpp). This moves it into the board-level ADC callbacks in analog_inputs.cpp, matching the existing ADS79xx SPI ADC integration pattern.
The gimbal driver now owns all its synchronization: GPIO init, HALL_SYNC assert/deassert, and V2 command sequencing. No hardware-specific code remains in hal/ or tasks/.