i#7487: fix tool's crashes due to cfg thunk implemented on 24h2 and above#7713
Open
x9090 wants to merge 1 commit into
Open
i#7487: fix tool's crashes due to cfg thunk implemented on 24h2 and above#7713x9090 wants to merge 1 commit into
x9090 wants to merge 1 commit into
Conversation
…bove This commit fixes the crashes on the tool when it encounters cfg thunks `guard_dispatch_icall$thunk$xxx` that was dereferenced to extended image memory located at ntdll by OS kernel, which leads to invalid memory for private library. Apart from that, `redirect_GetModuleFileNameW` seems to be broken as it returns the ascii version for the filename instead of unicode version. Fixes DynamoRIO#7487
Author
|
Apparently, the fix in From the CI's logs, it turns out that the tools/applications attempt to call drsyms module will lead to the loading of 2025-11-13T03:13:48.6140630Z 204: Test command: D:\a\dynamorio\dynamorio\build_debug-internal-64\bin64\drrun.exe "-s" "90" "-quiet" "-debug" "-use_dll" "D:/a/dynamorio/dynamorio/build_debug-internal-64/lib64/debug/dynamorio.dll" "-exit0" "-stderr_mask" "0xC" "-msgbox_mask" "0" "-dumpcore_mask" "0x7d" "-staged" "-code_api" "-c" "D:/a/dynamorio/dynamorio/build_debug-internal-64/api/samples/../bin/instrcalls.dll" "--" "D:/a/dynamorio/dynamorio/build_debug-internal-64/suite/tests/bin/common.eflags.exe"
2025-11-13T03:13:48.6926549Z 204: Working Directory: D:/a/dynamorio/dynamorio/build_debug-internal-64/suite/tests
2025-11-13T03:13:48.7241676Z 204: Test timeout computed to be: 120
2025-11-13T03:13:48.8021294Z 204: <Application D:\a\dynamorio\dynamorio\build_debug-internal-64\suite\tests\bin\common.eflags.exe (2096). Unable to load client library: D:\a\dynamorio\dynamorio\build_debug-internal-64\api\bin/symsrv.dll
2025-11-13T03:13:48.8957432Z 204: Cannot find library.> |
Contributor
|
Thank you for contributing. Please request a review when all the tests have passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the crashes on the tool when it encounters cfg thunks
guard_dispatch_icall$thunk$xxxthat was dereferenced to extended image memory located at ntdll by OS kernel, which leads to invalid memory for private library.Apart from that,
redirect_GetModuleFileNameWseems to be broken as it returns the ascii version for the filename instead of unicode version.Fixes #7487