Skip to content

Added build steps for Android clients#1928

Open
ctrippel wants to merge 2 commits into
DynamoRIO:masterfrom
ctrippel:android
Open

Added build steps for Android clients#1928
ctrippel wants to merge 2 commits into
DynamoRIO:masterfrom
ctrippel:android

Conversation

@ctrippel
Copy link
Copy Markdown

@ctrippel ctrippel closed this Apr 21, 2016
@ctrippel ctrippel reopened this Apr 21, 2016
@zhaoqin
Copy link
Copy Markdown
Contributor

zhaoqin commented Apr 21, 2016

Please xref https://github.com/DynamoRIO/dynamorio/wiki/Workflow about the
workflow and how to request for review.

On Thu, Apr 21, 2016 at 12:31 PM, ctrippel [email protected] wrote:

Reopened #1928 #1928.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1928 (comment)

derekbruening
derekbruening previously approved these changes Feb 15, 2017
Copy link
Copy Markdown
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've changed our workflow and are now using pull requests. This diff still looks useful so let's merge it in.

@derekbruening derekbruening dismissed their stale review February 15, 2017 02:10

My mistake, this was superceded by https://codereview.appspot.com/297890043/diff/1/api/docs/samples.dox, where we noted that toolchain-android.cmake is not exported.

@fhahn
Copy link
Copy Markdown
Contributor

fhahn commented Apr 10, 2017

@ctrippel it seems like the Travis & appveyor jobs got stuck and AFAIK Github won't allow submitting the change until they pass.

Could you update the branch (by just pressing the button next to the This branch is out-of-date with the base branch message)? This should trigger them again.

@fhahn
Copy link
Copy Markdown
Contributor

fhahn commented Dec 13, 2017

run aarch64 tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants