Merge branch 'D4R_DA' into D4DA_2026 by pinzart90 · Pull Request #3304 · DynamoDS/DynamoRevit

pinzart90 · 2026-03-25T14:10:08Z

Please Note:

Before submitting the PR, please review How to Contribute to Dynamo
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

The code base is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

mjkkirschner · 2026-03-25T20:12:05Z

src/Config/CS_SDK.props

    <PlatformTarget >x64</PlatformTarget>
    <Prefer32Bit>false</Prefer32Bit>
-    <Platforms>NET100</Platforms>
+    <Platforms>NET100;NET80_DA</Platforms>


I'm so confused, I thought for 2026 we would not be supporting net 10? Is this because of net10 back port?

YEs, I know
ANd yes, because of backport

mjkkirschner · 2026-03-25T20:12:21Z

src/Config/CS_SDK.props

-    <DCoreLibSubFolder>net10.0</DCoreLibSubFolder>
+    <TargetFramework Condition="'$(Platform)' == 'NET80_DA'">net8.0-windows</TargetFramework>
+    <DCoreLibSubFolder Condition="'$(Platform)' == 'NET80_DA'">net8.0</DCoreLibSubFolder>
+    <DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net8.0</DCoreLibSubFolder>


net10 points to net8?

that is supposed to be net10. Will fix

mjkkirschner · 2026-03-25T20:14:07Z

src/DADynamoApp/DADynamoApp.csproj

+        </Reference>
+    </ItemGroup>
+    <Target Name="Copy dll" AfterTargets="Build">
+        <Copy SourceFiles="$(PkgGregRevitAuth)\lib\$(DotnetVerSubFolder)\GregRevitAuth.dll" DestinationFolder="$(OutputPath)" />


we copy this because DA does not provide it?

mjkkirschner · 2026-03-25T20:15:18Z

@pinzart90 did you verify that Revit.All builds?
Does Revit.All include the Revit.DA solution or Revit All is not a true superset?

mjkkirschner · 2026-03-25T20:16:49Z

src/BUILDSYSTEM_TODO.md

@@ -0,0 +1,106 @@
+# Build System Cleanup — Open Questions & TODOs
+
+These are known issues and open design questions in the build system that need


can you have go through this and note what is now done after this PR? Have an agent do this?

pinzart90 · 2026-03-25T20:17:44Z

@pinzart90 did you verify that Revit.All builds? Does Revit.All include the Revit.DA solution or Revit All is not a true superset?
Revit All is not a true superset
I did not validate that Revit.All builds yet.

mjkkirschner · 2026-03-25T20:18:06Z

src/Libraries/RevitServices/Persistence/DocumentManager.cs

+                if (!d.IsLinked)
+                {
+                    CurrentDBDocument = d;
+                    break;


I don't remember seeing this code before - so it just picks the first doc, how could more than 1 doc be loaded?

pinzart90 · 2026-03-25T20:19:17Z

I don't think we'll merge this PR into 2026. This is going to live as a branch I imagine.
We'll probably attempt a merge back to master with 2027

mjkkirschner · 2026-03-25T20:21:26Z

src/DADynamoApp/SetupDARequest.cs

+    {
+        //
+        // Summary:
+        // Save the revit document to the default result.rvt file.


is this still accurate?

mjkkirschner · 2026-03-25T20:24:42Z

src/DADynamoApp/DAEntrypoint.cs

+
+                RevitServices.Transactions.TransactionManager.SetupManager(new RevitServices.Transactions.AutomaticTransactionStrategy());
+                // TODO: do we need element binding in Design Automations?
+                ElementBinder.IsEnabled = true;


good question... If the rvt has elements that would be rebound then it could be good - but I feel like we should default to off... element binding mostly make sense when you have the same call sites executing repeatedly like when interacting with a graph - we can't have that here.

mjkkirschner · 2026-03-25T20:26:40Z

@pinzart90 - at some point it would be good to take this branch / set of commits / this PR and try to generate/propose a real plan for getting this merged with D4R - long term do you think the solution is splitting of the addin into 2 addins or sticking with the defines?

Please Note: 1. Before submitting the PR, please review [How to Contribute to Dynamo](https://github.com/DynamoDS/Dynamo/blob/master/CONTRIBUTING.md) 2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately) 3. PRs will be reviewed from oldest to newest 4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team 5. PRs should use either Dynamo's default PR template or [one of these other template options](https://github.com/DynamoDS/Dynamo/wiki/Choosing-a-Pull-Request-Template) in order to be considered for review. 6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team. 7. PRs made to the `DynamoRevit` repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a `LGTM` label is added to the PR. ### Purpose (FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for. ### Declarations Check these if you believe they are true - [ ] The code base is in a better state after this PR - [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards) - [ ] The level of testing this PR includes is appropriate - [ ] User facing strings, if any, are extracted into `*.resx` files - [ ] Snapshot of UI changes, if any. ### Reviewers (FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR) (FILL ME IN, optional) Any additional notes to reviewers or testers. ### FYIs (FILL ME IN, Optional) Names of anyone else you wish to be notified of

### Purpose Add default output folder ### Declarations Check these if you believe they are true - [ ] The code base is in a better state after this PR - [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards) - [ ] The level of testing this PR includes is appropriate - [ ] User facing strings, if any, are extracted into `*.resx` files - [ ] Snapshot of UI changes, if any. ### Reviewers (FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR) (FILL ME IN, optional) Any additional notes to reviewers or testers. ### FYIs (FILL ME IN, Optional) Names of anyone else you wish to be notified of

pinzart90 and others added 2 commits March 25, 2026 10:01

Merge branch 'D4R_DA' into D4DA_2026

d93e55d

Merge branch 'Revit2026' into D4DA_2026

ece8884

mjkkirschner reviewed Mar 25, 2026

View reviewed changes

mjkkirschner approved these changes Mar 25, 2026

View reviewed changes

pinzart90 added 2 commits March 27, 2026 07:06

		@@ -0,0 +1,106 @@
		# Build System Cleanup — Open Questions & TODOs

		These are known issues and open design questions in the build system that need

Conversation

pinzart90 commented Mar 25, 2026

Purpose

Declarations

Reviewers

FYIs

Uh oh!

mjkkirschner Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

pinzart90 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pinzart90 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mjkkirschner commented Mar 25, 2026

Uh oh!

mjkkirschner Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pinzart90 commented Mar 25, 2026

Uh oh!

mjkkirschner Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

pinzart90 commented Mar 25, 2026

Uh oh!

mjkkirschner Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mjkkirschner commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mjkkirschner Mar 25, 2026 •

edited

Loading

mjkkirschner Mar 25, 2026 •

edited

Loading