Skip to content

d4r for design automation#3152

Draft
pinzart90 wants to merge 75 commits intomasterfrom
D4R_DA
Draft

d4r for design automation#3152
pinzart90 wants to merge 75 commits intomasterfrom
D4R_DA

Conversation

@pinzart90
Copy link
Copy Markdown
Collaborator

@pinzart90 pinzart90 commented Apr 4, 2025

Minimal changes to get D4R working on Design automation
This PR is based on RC3.3.0_Revit2025 because the latest Revit on DA seems to be 2025

I opted to use "if def"s in order to minimize the changes and avoid breaking changes. As a follow up task we should do a proper separation of Core and UI functionality in all the projects (this will most likely mean breaking changes).
I will create a couple of jira tasks with proposed changes to pursue this further.

zeusongit and others added 27 commits January 12, 2024 15:15
OnRequestsCrashPrompt function
Update Greg to 3.0.1
Update Greg to 3.0.1
* update GregRevitAuth to 3.0.8935.26399
* update GregRevitAuth to 3.0.8935.26399
* add OOTB templates
* update Dynamo Core build to 3.2.1.5366
* add wrapper over Revit RoofBase class to D4R Roof class

* cast value data type to parameter value data type in order to avoid blind pointer cast in revit later on

* cast value data type to parameter value data type, get parameter value data type from Storage type where value is null
@pinzart90 pinzart90 changed the base branch from master to RC3.3.0_Revit2025 April 4, 2025 16:20
pinzart90 and others added 24 commits April 25, 2025 09:13
add saveRvt option
What changed:
Ability to load Revit Cloud Models
("type":"versions:autodesk.bim360:C4RModel")

Documentation 

https://aps.autodesk.com/blog/new-sample-support-access-revit-cloud-model-revit-design-automation-engine

Not implemented yet: Cloud Shared models.
Does not work for regular rvt files stored on ACC (only supported in
Autocad for now) -
https://aps.autodesk.com/en/docs/design-automation/v3/developers_guide/reference-downloading/

TODO:
To access cloud models using Automation, you need to provide the user
context through a special workitem argument; adsk3LeggedToken,
scope=code:all needs to be added to your authorization call.
I need to add an example in the scripts/postman collections
@pinzart90 pinzart90 changed the base branch from master to Revit2026 March 9, 2026 17:31
@pinzart90 pinzart90 changed the base branch from Revit2026 to master March 9, 2026 17:32
pinzart90 and others added 4 commits March 9, 2026 13:38
Temporary changes until we rebase to 2026 or use revit 2027
~~⚠️ do not merge while this branch targets net8 / dynamo 3.5 - can only
ref dynamo 4.0~~ Retargeted to work in Revit 2026 / Dynamo 3.5.

I will send another PR and create a new branch for D4R_DA_2027

untested!

* `service mode` already redirects logger to std out.
* we inject some profiling and send them to std out so they are captured
in da logs.
*  test
* added daapp.csproj to revit.all.sln - but unsure on this.
* added a TODO file because I think there is a lot of cleanup required
in this repo.



@pinzart @pinzart90 I am thinking this branch (`D4R_DA`) gets renamed to
D4R_DA_2026 and we rip out all the NET10 stuff - sound good?
ISolate the DA Application class from the rest of the implementation so
that we can handle setup an Assembly resolver before all the
dependencies need to get solved.


Please Note:
1. Before submitting the PR, please review [How to Contribute to
Dynamo](https://github.com/DynamoDS/Dynamo/blob/master/CONTRIBUTING.md)
2. Dynamo Team will meet 1x a month to review PRs found on Github
(Issues will be handled separately)
3. PRs will be reviewed from oldest to newest
4. If a reviewed PR requires changes by the owner, the owner of the PR
has 30 days to respond. If the PR has seen no activity by the next
session, it will be either closed by the team or depending on its
utility will be taken over by someone on the team
5. PRs should use either Dynamo's default PR template or [one of these
other template
options](https://github.com/DynamoDS/Dynamo/wiki/Choosing-a-Pull-Request-Template)
in order to be considered for review.
6. PRs that do not have one of the Dynamo PR templates completely filled
out with all declarations satisfied will not be reviewed by the Dynamo
team.
7. PRs made to the `DynamoRevit` repo will need to be cherry-picked into
all the DynamoRevit Release branches that Dynamo supports. Contributors
will be responsible for cherry-picking their reviewed commits to the
other branches after a `LGTM` label is added to the PR.

### Purpose

(FILL ME IN) This section describes why this PR is here. Usually it
would include a reference
to the tracking task that it is part or all of the solution for.

### Declarations

Check these if you believe they are true

- [ ] The code base is in a better state after this PR
- [ ] Is documented according to the
[standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)
- [ ] The level of testing this PR includes is appropriate
- [ ] User facing strings, if any, are extracted into `*.resx` files
- [ ] Snapshot of UI changes, if any.

### Reviewers

(FILL ME IN) Reviewer 1  (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

### FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of
### Purpose

https://jira.autodesk.com/browse/DYN-10310
Cannot save rvt after running graph

### Declarations

Check these if you believe they are true

- [ ] The code base is in a better state after this PR
- [ ] Is documented according to the
[standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)
- [ ] The level of testing this PR includes is appropriate
- [ ] User facing strings, if any, are extracted into `*.resx` files
- [ ] Snapshot of UI changes, if any.

### Reviewers

(FILL ME IN) Reviewer 1  (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

### FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants