fix(subsecond): gate browser deps on target_os = "unknown" so WASI builds#5602
Open
harryzz wants to merge 1 commit into
Open
fix(subsecond): gate browser deps on target_os = "unknown" so WASI builds#5602harryzz wants to merge 1 commit into
harryzz wants to merge 1 commit into
Conversation
…ilds Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subsecondgates its browser deps (wasm-bindgen, js-sys, web-sys, wasm-bindgen-futures) and theapply_patchhot-reload path oncfg(target_arch = "wasm32"). That also matches non-browser wasm targets likewasm32-wasip2/wasm32-wasip1, where theweb_sys::window().fetch(...)path is meaningless and wasm-bindgen's imports don't link — so anything depending ondioxus-core(which depends onsubsecond) fails to build for WASI / component-model targets.This narrows the gate to
all(target_arch = "wasm32", target_os = "unknown")(browser only). On WASI,apply_patchfalls through to its existingOk(())(hot-patch is a no-op there). No change for browser or native targets.Tested: a dioxus 0.7 cdylib then builds as a valid wasm32-wasip2 component with no wasm-bindgen in the dependency tree.
This patch was written with Claude (AI assistant) and reviewed + explicitly approved by me before submitting.