Skip to content

fix: set SDK model FPS to 30#137

Open
AdirAmsalem wants to merge 1 commit into
mainfrom
rene/set-model-fps-30
Open

fix: set SDK model FPS to 30#137
AdirAmsalem wants to merge 1 commit into
mainfrom
rene/set-model-fps-30

Conversation

@AdirAmsalem
Copy link
Copy Markdown
Contributor

@AdirAmsalem AdirAmsalem commented May 14, 2026

Summary

  • Set every SDK model registry definition to fps: 30
  • Update existing FPS assertions and add a registry-wide test that all listed model definitions expose 30 FPS

Validation

  • pnpm format:check (passes with existing Biome warnings)
  • pnpm lint (passes with existing Biome warnings)
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • Independent Claude Code review: no blockers

Requested by Dore in Slack (source channel) - message link


Note

Low Risk
Low risk metadata change, but it updates a public SDK contract (fps) and could affect consumers that assume the previous per-model FPS values.

Overview
All SDK-registered model definitions (realtime/video/image, including latest and deprecated aliases) are updated to expose fps: 30 in packages/sdk/src/shared/model.ts.

Unit tests are updated to assert the new FPS values and a new registry-wide test ensures listModels() returns only 30 FPS definitions.

Reviewed by Cursor Bugbot for commit 0622ec4. Bugbot is set up for automated code reviews on this repo. Configure here.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@decartai/sdk@137

commit: 0622ec4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant