fix: set SDK model FPS to 30#137
Open
AdirAmsalem wants to merge 1 commit into
Open
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fps: 30Validation
pnpm format:check(passes with existing Biome warnings)pnpm lint(passes with existing Biome warnings)pnpm typecheckpnpm testpnpm buildRequested by Dore in Slack (source channel) - message link
Note
Low Risk
Low risk metadata change, but it updates a public SDK contract (
fps) and could affect consumers that assume the previous per-model FPS values.Overview
All SDK-registered model definitions (realtime/video/image, including latest and deprecated aliases) are updated to expose
fps: 30inpackages/sdk/src/shared/model.ts.Unit tests are updated to assert the new FPS values and a new registry-wide test ensures
listModels()returns only 30 FPS definitions.Reviewed by Cursor Bugbot for commit 0622ec4. Bugbot is set up for automated code reviews on this repo. Configure here.