fix(shared): augment PATH with common Unix tool locations#808
Merged
horza-bora merged 3 commits intomainfrom Apr 12, 2026
Merged
fix(shared): augment PATH with common Unix tool locations#808horza-bora merged 3 commits intomainfrom
horza-bora merged 3 commits intomainfrom
Conversation
Dave-London
added a commit
that referenced
this pull request
Apr 12, 2026
- Add explicit timeout parameters (180_000 for beforeAll, 30_000 for afterAll) to the write-tool integration test hooks in server-git, preventing McpError: Connection closed on slow CI environments - Apply the same timeout fix across all 13 server integration test files - Add tests for batch branch deletion flag injection in delete array - Add tests for forceDelete string param (PR #807) - Add tests verifying dash-prefixed build args pass validation (PR #805) - Add tests for PATH augmentation: non-existent paths skipped, and end-to-end verification of augmented paths (PR #808)
4 tasks
- Remove startsWith("/") assertion that fails on Windows paths
- Normalize backslash paths in duplicate-detection test
- Remove unused pathAfterFirst variables (lint errors)
The "does not duplicate" test constructs Unix-style paths that don't match Windows backslash paths from join(), causing false duplicates. Skip on Windows since _augmentUnixPath is a no-op there anyway.
Dave-London
added a commit
that referenced
this pull request
Apr 12, 2026
- Add explicit timeout parameters (180_000 for beforeAll, 30_000 for afterAll) to the write-tool integration test hooks in server-git, preventing McpError: Connection closed on slow CI environments - Apply the same timeout fix across all 13 server integration test files - Add tests for batch branch deletion flag injection in delete array - Add tests for forceDelete string param (PR #807) - Add tests verifying dash-prefixed build args pass validation (PR #805) - Add tests for PATH augmentation: non-existent paths skipped, and end-to-end verification of augmented paths (PR #808)
horza-bora
approved these changes
Apr 12, 2026
Merged
Dave-London
added a commit
that referenced
this pull request
Apr 12, 2026
- Add explicit timeout parameters (180_000 for beforeAll, 30_000 for afterAll) to the write-tool integration test hooks in server-git, preventing McpError: Connection closed on slow CI environments - Apply the same timeout fix across all 13 server integration test files - Add tests for batch branch deletion flag injection in delete array - Add tests for forceDelete string param (PR #807) - Add tests verifying dash-prefixed build args pass validation (PR #805) - Add tests for PATH augmentation: non-existent paths skipped, and end-to-end verification of augmented paths (PR #808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/shared/src/runner.tsto fix ENOENT errors when MCP clients (Codex, Claude Desktop, etc.) launch server processes with a stripped PATH that omits/opt/homebrew/bin,/usr/local/bin, etc._WIN32_FALLBACK_PATHSpattern: on firstrun()call, checks common Unix tool directories (/opt/homebrew/bin,/opt/homebrew/sbin,/usr/local/bin,/usr/local/sbin,~/.cargo/bin,~/.local/bin), and prepends those that exist on disk but are missing from PATH.Closes #803
Test plan
pnpm --filter @paretools/shared buildpassespnpm --filter @paretools/shared testpasses (421 tests)fd/rgtools work in Claude Desktop on macOS with Homebrew