antithesis(logs): services store has a latent deadlock (dormant)

[blt]

What does this PR do?

Adds a test for a hidden deadlock risk in the container "services" store: it holds its lock while sending to subscribers, so a slow subscriber blocks everything. (The sources store does this the safe way — it releases the lock first.) Off in normal CI (antithesis_demo tag).

Motivation

Part of the logs-agent Antithesis work.

Describe how you validated your changes

go test -tags "antithesis_demo test" -run TestAntithesisDeadlock ./pkg/logs/service/ -v. Shows the block.

Additional Notes

This can't actually happen today — nothing in production subscribes to this store, so the risky loop never runs. It's here as a guard in case a subscriber is added later. Doesn't run in normal CI. No agent code changed.

[blt]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• antithesis(logs): container races drop logs and mislabel metadata #51512
• antithesis(logs): services store has a latent deadlock (dormant) #51511 👈 (View in Graphite)
• antithesis(logs): auditor loses or duplicates logs around crashes #51510
• antithesis(logs): pipeline failover hangs/crashes on shutdown and reorders logs #51509
• antithesis(logs): sender drops logs and crashes on double-stop #51508
• antithesis(logs): adaptive sampler counting guard (bug already fixed) #51507
• antithesis(logs): wildcard file picker can drop the wrong file #51506
• antithesis(logs): file tailer drops and re-reads logs (rotation, seek, multi-line) #51505
• antithesis(logs): harness to run the logs agent on Antithesis #51515
• antithesis(logs): logs-agent research artifacts #51504
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[datadog-prod-us1-3]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 16 Pipeline jobs failed

DataDog/datadog-agent | new-e2e-cws: [--run TestAgentSuiteEC2]     

🔄 Retry job. This looks flaky and may succeed on retry.

Agent rule creation failed due to 409 Conflict error at common.go:119 in Test03OpenSignal.

DataDog/datadog-agent | new-e2e-cws: [--run TestAgentSuiteGCP]     

🔄 Retry job. This looks flaky and may succeed on retry.

Agent rule creation failed. Received unexpected error: 409 Conflict at /go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/cws/common.go:119 in test TestAgentSuiteGCP/Test03OpenSignal.

DataDog/datadog-agent | new-e2e-cws: [--run TestKindSuite]     

🔄 Retry job. This looks flaky and may succeed on retry.

2 failed tests in TestKindSuite. Error: Received unexpected error: no log found for ruleset_loaded event for host cws-e2e-kind-node-1dd1.

View all 16 failed jobs.

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.42% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9434654 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 8ff8f30e:

Results for datadog-agent_7.81.0~devel.git.319.9434654.pipeline.115988653-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8ff8f30
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	746.165 MiB
✅	agent_deb_amd64_fips	703.944 MiB
✅	agent_heroku_amd64	310.712 MiB
✅	agent_msi	610.086 MiB
✅	agent_rpm_amd64	746.149 MiB
✅	agent_rpm_amd64_fips	703.927 MiB
✅	agent_rpm_arm64	723.727 MiB
✅	agent_rpm_arm64_fips	684.651 MiB
✅	agent_suse_amd64	746.149 MiB
✅	agent_suse_amd64_fips	703.927 MiB
✅	agent_suse_arm64	723.727 MiB
✅	agent_suse_arm64_fips	684.651 MiB
✅	docker_agent_amd64	806.318 MiB
✅	docker_agent_arm64	808.705 MiB
✅	docker_agent_jmx_amd64	997.238 MiB
✅	docker_agent_jmx_arm64	988.403 MiB
✅	docker_cluster_agent_amd64	207.101 MiB
✅	docker_cluster_agent_arm64	221.078 MiB
✅	docker_cws_instrumentation_amd64	7.154 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.511 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	docker_host_profiler_amd64	302.118 MiB
✅	docker_host_profiler_arm64	313.592 MiB
✅	dogstatsd_deb_amd64	30.166 MiB
✅	dogstatsd_deb_arm64	28.292 MiB
✅	dogstatsd_rpm_amd64	30.166 MiB
✅	dogstatsd_suse_amd64	30.166 MiB
✅	iot_agent_deb_amd64	44.460 MiB
✅	iot_agent_deb_arm64	41.429 MiB
✅	iot_agent_deb_armhf	42.146 MiB
✅	iot_agent_rpm_amd64	44.461 MiB
✅	iot_agent_suse_amd64	44.461 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e457f506-4ba0-4194-b805-997b2c7a6dbd

Baseline: 8ff8f30
Comparison: 9434654
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.55	[-3.46, +2.36]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.51	[+0.34, +0.69]	1	Logs
➖	ddot_logs	memory utilization	+0.47	[+0.41, +0.53]	1	Logs
➖	file_tree	memory utilization	+0.18	[+0.14, +0.23]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.12	[-0.13, +0.37]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.07, +0.17]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.05	[-0.34, +0.45]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.04	[-0.97, +1.05]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.04	[-0.01, +0.08]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.45, +0.52]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.19, +0.22]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.00	[-0.44, +0.44]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.09, +0.09]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.23, +0.18]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.07	[-0.12, -0.02]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.08	[-0.23, +0.08]	1	Logs
➖	quality_gate_idle	memory utilization	-0.15	[-0.20, -0.10]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.21	[-0.45, +0.02]	1	Logs
➖	docker_containers_memory	memory utilization	-0.25	[-0.34, -0.15]	1	Logs
➖	ddot_metrics	memory utilization	-0.26	[-0.47, -0.06]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.28	[-0.38, -0.18]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.31	[-0.50, -0.12]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.36	[-0.51, -0.20]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.55	[-3.46, +2.36]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	612 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	243.56MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	694 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	144.01MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	739.23KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	474.60MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	172.86MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.33MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	351.43 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	370.51MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.