[WP] Fix filtersToProgs

[theop-dd]

What does this PR do?

Fix the function filtersToProgs.

Motivation

The function was intended to generate programs capped at 4,000 instructions. However, the algorithm would split the program only after adding the filter that caused the instruction limit to be exceeded.

Describe how you validated your changes

Here is an example of the sizes of the progs before and after the fix.

=== RUN   TestRawPacketFilter/all-with-limit
len(prog.Instructions): 7142
len(prog.Instructions): 7126
len(prog.Instructions): 7146
len(prog.Instructions): 7102
len(prog.Instructions): 7138
len(prog.Instructions): 3555

After the fix the test fails because we need more than 5 tail calls.

=== RUN   TestRawPacketFilter/all-with-limit
    network_test.go:799:
        	Error Trace:	/Users/theo.putegnat/dd/datadog-agent/pkg/security/tests/network_test.go:799
        	            				/Users/theo.putegnat/dd/datadog-agent/pkg/security/tests/network_test.go:841
        	Error:      	Received unexpected error:
        	            	1 error occurred:
        	            		* maximum allowed tail calls reach: 5 vs 5

        	Test:       	TestRawPacketFilter/all-with-limit
len(prog.Instructions): 3591
len(prog.Instructions): 3577
len(prog.Instructions): 3562
len(prog.Instructions): 3590
len(prog.Instructions): 3572
len(prog.Instructions): 3596

For example, the first filter contains 87 instructions (3,500 NOPs), including all the additional instructions. After the fix, the instruction count increases by 4 due to the insertion of the tail call.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4886b8e41

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Chain into the final split program

When the filter being moved to a new program is the last filter (i+1 == len(filters)), tailCallInsts is empty, but this branch still finalizes the previous program and starts a new one. The previous program then falls through to footerInsts without a tail call, so the newly-created final program is loaded into the prog array but is never reachable; on older kernels with MaxProgSize 4000 this means a last large raw-packet/drop-action filter can be silently ignored whenever it does not fit after earlier filters. The split path needs a tail call whenever there are remaining filters in the next program, including the current last filter.

Useful? React with 👍 / 👎.

[theop-dd]

Done, I removed the condition on the last filter.

[datadog-datadog-prod-us1-2]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 12 Pipeline jobs failed

DataDog/datadog-agent | tests_ebpf_arm64     

🔧 Fix in code (Fix with Cursor).

2 tests failed. Error: expected programs not generated: expected: 1, actual: 0; expected: 2, actual: 0 along with return code error -1 in raw_packet_test.go:80

DataDog/datadog-agent | tests_ebpf_x64     

🔧 Fix in code (Fix with Cursor).

2 failed tests in raw_packet_test.go: expected 1 and 2 programs but got 0 each, return code error was -1.

DataDog/datadog-agent | new-e2e-cspm     

🔄 Retry job. This looks flaky and may succeed on retry.

Source fetch failed due to gitretriever command termination with exit code 1. Deleting tracked and untracked files as a result.

View all 12 failed jobs.

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.57% (+0.14%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: df89cd6 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor f053e31a:

Results for datadog-agent_7.81.0~devel.git.314.df89cd6.pipeline.115931590-1_amd64.deb:

No change detected

[safchain]

Is it not :

// where each prog is like this
// header -> filter 1 -> filter 2 -> ... -> filter n -> footer

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b7e6a376-12da-461b-8c5b-f93a2de467ea

Baseline: f053e31
Comparison: df89cd6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.66	[-3.58, +2.26]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.56	[-0.45, +1.58]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.51	[+0.47, +0.55]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.07	[+0.02, +0.12]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	+0.07	[-0.09, +0.22]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.03	[-0.17, +0.23]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.11, +0.13]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.00	[-0.41, +0.41]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.20, +0.19]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.52, +0.51]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.11, +0.09]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.03	[-0.19, +0.14]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.05	[-0.50, +0.40]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.07	[-0.12, -0.03]	1	Logs
➖	file_tree	memory utilization	-0.11	[-0.15, -0.06]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.14	[-0.38, +0.11]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.22	[-0.46, +0.01]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.24	[-0.42, -0.05]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.26	[-0.35, -0.16]	1	Logs
➖	ddot_logs	memory utilization	-0.37	[-0.43, -0.32]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.47	[-0.63, -0.31]	1	Logs
➖	ddot_metrics	memory utilization	-0.49	[-0.69, -0.28]	1	Logs
➖	docker_containers_memory	memory utilization	-0.59	[-0.69, -0.49]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.66	[-3.58, +2.26]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	722 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	245.89MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	706 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	141.97MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	743.00KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	474.21MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	173.32MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.95MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	340.03 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	376.72MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.