packaging/aix: use generic gcc name in CC so pip install works with any GCC version#51497
Conversation
pgimalac
added
changelog/no-changelog
|
@codex review |
github-actions
Bot
added
the
short review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a619b2fffe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Files inventory check summaryFile checks results against ancestor 205dba56: Results for datadog-agent_7.81.0~devel.git.343.0ad38b5.pipeline.116003757-1_amd64.deb:No change detected |
github-actions
Bot
added
medium review
pgimalac
force-pushed
the
pgimalac/aix-gcc-wrapper
branch
from
a619b2f to
807583b
Compare
|
@codex review |
…any GCC On the build host /opt/freeware/bin/gcc already points to gcc-13, so we create private gcc/g++ symlinks in $BUILD_DIR/bin pointing to gcc-8 and prepend that directory to PATH before setting CC=gcc and CXX=g++. Previously CC was set to the full path /opt/freeware/bin/gcc-8, which Python records verbatim in _sysconfigdata_. When customers run pip install for C extensions (e.g. ibm_db), setuptools reads CC from sysconfig and tries to invoke gcc-8 by name — failing on systems where only gcc-10 or gcc-13 is installed, even though those versions produce ABI-compatible code. With CC=gcc (no path, no version suffix), the recorded compiler is the generic name that any GCC version satisfies, giving customers a seamless pip install experience regardless of which GCC they have installed. The build itself is unchanged: both symlinks resolve to gcc-8, so all binaries continue to be compiled with GCC 8 for AIX 7.2 TL2 compatibility.
pgimalac
force-pushed
the
pgimalac/aix-gcc-wrapper
branch
from
807583b to
d3cdc9e
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: df4252f Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.84 | [-3.75, +2.07] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | ddot_logs | memory utilization | +0.39 | [+0.34, +0.45] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.28 | [+0.04, +0.51] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.12 | [+0.08, +0.16] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.36, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.04 | [-0.10, +0.19] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.22] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.19, +0.19] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.52, +0.51] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.12, +0.10] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.02 | [-0.27, +0.22] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.03 | [-0.47, +0.41] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.05 | [-0.24, +0.15] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.06 | [-0.11, -0.00] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.08 | [-0.24, +0.07] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.14 | [-0.19, -0.09] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.15 | [-0.30, +0.01] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.15 | [-0.27, -0.04] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.26 | [-0.31, -0.22] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.35 | [-0.54, -0.17] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.38 | [-1.42, +0.66] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.55 | [-0.65, -0.45] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.84 | [-3.75, +2.07] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.88 | [-1.08, -0.69] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 700 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 247.56MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 538 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 144.58MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 738.09KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 482.33MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.13MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 174.33MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 264.30MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 339.42 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 378.38MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.93GiB ≤ 1.04GiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
3 participants
What does this PR do?
Creates
gcc/g++symlinks pointing togcc-8in$BUILD_DIR/binand prepends that directory to PATH, then setsCC=gccandCXX=g++instead of the full versioned path.Motivation
Python records the
CCused at build time verbatim in_sysconfigdata_. Previously this was/opt/freeware/bin/gcc-8, sopip install ibm_db(or any C extension) on a customer host would fail ifgcc-8was not installed, even thoughgcc-10orgcc-13would work fine for that purpose.With
CC=gcc, the sysconfigdata records the generic name. Any GCC version in the customer's PATH satisfies it. The actual build still uses GCC 8 (via the symlink) for AIX 7.2 TL2 compatibility.Describe how you validated your changes
Build and validated pip install command on AIX.
Additional Notes
N/A