[CWS] make flags approvers win over parent-basename path approvers

[safchain]

When a path approver can only be expressed kernel-side as a parent-basename filter (e.g. open.file.path =~ "/var/run/secrets/*", where only the "secrets" directory name can be pushed down), it is a coarse filter that should not be preferred over a more selective approver such as open.flags.

Add a per-value FilterWeightFnc hook on FieldCapability so the path field reports a low weight (20) for parent-basename approvers and keeps its full weight (300) for precise leaf-basename ones. getApprovers takes the minimum weight across a field's values, and ComputeFilters applies the same logic when ordering capabilities for ApproverOnly conversion.

Add tests covering both the parent-basename (flags win) and leaf-basename (path wins) cases.

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

[datadog-prod-us1-4]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-agent | kmt_run_secagent_tests_x64: [oracle_8.9, cws_host]     

🔧 Fix in code (Fix with Cursor).

2 failed tests in pkg/security. Error: exit status 1 on TestSSHUserSession and TestSSHUserSession/ssh_then_pwd.

DataDog/datadog-agent | oracle: [21.3.0-xe]     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

2 failed tests: TestGetFullSqlText and TestConnectionGoOra. Error: failed to ping oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor.

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 72.73%
• Overall Coverage: 50.43% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 08bfe1f | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 52ff4d4c:

Results for datadog-agent_7.81.0~devel.git.311.08bfe1f.pipeline.115912078-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 52ff4d4
📊 Static Quality Gates Dashboard
🔗 SQG Job

Error

	Quality gate	Change	Size (prev → curr → max)
⚠️	docker_agent_amd64 (on disk)	neutral	806.346 MiB → 806.340

Gate failure full details

Quality gate	Error type	Error message
docker_agent_amd64	AbsoluteLimitExceeded (non-blocking: size unchanged from ancestor)	static_quality_gate_docker_agent_amd64 failed! Disk size 806.3 MB exceeds limit of 806.3 MB by 5.9 KB

Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit.

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64_fips	+7.5 KiB (0.00% increase, -2.16% of buffer)	703.960 → 703.968 → 704.300
✅	agent_rpm_amd64_fips	+7.5 KiB (0.00% increase, -2.06% of buffer)	703.944 → 703.951 → 704.300
✅	agent_rpm_arm64	+9.19 KiB (0.00% increase, -1.19% of buffer)	723.743 → 723.752 → 724.500
✅	agent_rpm_arm64_fips	+5.19 KiB (0.00% increase, -2.50% of buffer)	684.667 → 684.672 → 684.870
✅	agent_suse_amd64_fips	+7.5 KiB (0.00% increase, -2.06% of buffer)	703.944 → 703.951 → 704.300
✅	agent_suse_arm64	+9.19 KiB (0.00% increase, -1.19% of buffer)	723.743 → 723.752 → 724.500
✅	agent_suse_arm64_fips	+5.19 KiB (0.00% increase, -2.50% of buffer)	684.667 → 684.672 → 684.870
✅	docker_agent_arm64	+9.2 KiB (0.00% increase, -0.64% of buffer)	808.721 → 808.730 → 810.120
✅	docker_agent_jmx_arm64	+9.19 KiB (0.00% increase, -0.65% of buffer)	988.419 → 988.428 → 989.800

22 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	746.193 MiB
✅	agent_heroku_amd64	310.715 MiB
✅	agent_rpm_amd64	746.177 MiB
✅	agent_suse_amd64	746.177 MiB
✅	docker_agent_jmx_amd64	997.266 MiB
✅	docker_cluster_agent_amd64	207.101 MiB
✅	docker_cluster_agent_arm64	221.078 MiB
✅	docker_cws_instrumentation_amd64	7.154 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.511 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	docker_host_profiler_amd64	302.122 MiB
✅	docker_host_profiler_arm64	313.591 MiB
✅	dogstatsd_deb_amd64	30.166 MiB
✅	dogstatsd_deb_arm64	28.292 MiB
✅	dogstatsd_rpm_amd64	30.166 MiB
✅	dogstatsd_suse_amd64	30.166 MiB
✅	iot_agent_deb_amd64	44.460 MiB
✅	iot_agent_deb_arm64	41.429 MiB
✅	iot_agent_deb_armhf	42.146 MiB
✅	iot_agent_rpm_amd64	44.461 MiB
✅	iot_agent_suse_amd64	44.461 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 48c14ef1-0409-46f5-9255-7af7b5a52ea5

Baseline: 52ff4d4
Comparison: 08bfe1f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.83	[-2.14, +3.80]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.83	[-2.14, +3.80]	1	Logs
➖	file_tree	memory utilization	+0.61	[+0.57, +0.65]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.42	[+0.22, +0.61]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.38	[+0.28, +0.47]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.28	[+0.12, +0.44]	1	Logs
➖	docker_containers_memory	memory utilization	+0.17	[+0.06, +0.27]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.12	[-0.11, +0.36]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.07	[+0.02, +0.12]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.09, +0.18]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.04	[-0.16, +0.24]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.02	[-0.43, +0.46]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.40, +0.41]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.09, +0.10]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.03	[-0.06, +0.01]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	-0.07	[-0.60, +0.46]	1	Logs
➖	ddot_logs	memory utilization	-0.07	[-0.14, -0.01]	1	Logs
➖	quality_gate_idle	memory utilization	-0.23	[-0.28, -0.18]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	-0.37	[-0.56, -0.17]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.54	[-0.78, -0.30]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	-0.60	[-0.79, -0.42]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.60	[-0.76, -0.45]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.45	[-3.45, -1.45]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	585 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	248.35MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	715 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	142.71MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	739.33KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	474.92MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	174.41MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.33MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	347.31 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	380.44MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.