Skip to content

Fix for Sketch v52 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmessager wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for Sketch v52 #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02d63ad
Change regex to prevent conflict with data-populator plugin
Oct 11, 2018
38d8386
Update regex
Oct 11, 2018
d6d1590
Fix for Sketch v52
Oct 26, 2018
52d4d3d
Modify link to download plugin
Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
*.DS_Store
.history
4 changes: 2 additions & 2 deletions Paddy.sketchplugin/Contents/Sketch/padding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Example padding object:
* Return if a layer can have padding associated with it
*/
function canLayerHavePadding(layer) {
return (layer.isMemberOfClass(MSShapeGroup) || layer.isMemberOfClass(MSSymbolInstance))
return (layer.isMemberOfClass(MSShapeGroup) || layer.isMemberOfClass(MSSymbolInstance) || layer.isMemberOfClass(MSRectangleShape))
}


Expand Down Expand Up @@ -86,7 +86,7 @@ function layerHasPadding(layer) {
function layerPaddingString(layer) {
if (!layer) return

var regex = /.*\[(.*)\]/g
var regex = /.*\[(.*)\](?!\.).*/g
return firstRegexMatch(regex, layer.name())
}

Expand Down
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<a href="https://github.com/DWilliames/paddy-sketch-plugin/archive/master.zip">
<a href="https://github.com/nmessager/paddy-sketch-plugin/archive/master.zip">
<img src=".images/banner-new.svg" alt="Paddy sketch plugin – automated padding and spacing for your Sketch layers"/>
</a>

---


![Using Paddy](.images/GIFs/main.gif)

<a href="https://github.com/DWilliames/paddy-sketch-plugin/archive/master.zip">
<a href="https://github.com/nmessager/paddy-sketch-plugin/archive/master.zip">
<img height="40" src=".images/download.svg" >
</a>

Expand Down