Handle central-publishing-maven-plugin for skipNotDeployed detection#604
Handle central-publishing-maven-plugin for skipNotDeployed detection#604apupier wants to merge 1 commit intoCycloneDX:masterfrom
Conversation
|
I think it will be worthy to add a test. (not understood well how to write a good integration test here yet). i'm also wondering if we should increase the plugin number to 2.30.0 as this is a new feature. |
90cb8a6 to
6d467ae
Compare
ppkarwasz
left a comment
There was a problem hiding this comment.
Looks great! 💯
Could you also add two tests to src/it/makeAggregateBom/skipped?
this is the plugin replacing nexus-maven-plugin. The goal used by this plugin is `publish` and not `deploy` as other ones Added tests covering the case of automatic bom generation when using this new Maven plugin and also when skipping it explicitly fix CycloneDX#597 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
6d467ae to
755491c
Compare
I added the two tests when skipping |
|
This PR will solve the immediate problem of projects that use the Since deployment plugins start appearing like mushrooms after a rain, in the long term we need a different strategy to deal with this. |
|
Any chances to have it reviewed? The service and so old plugin will be decommissioned in a week https://central.sonatype.org/news/20250326_ossrh_sunset/ , I suspect that potentially a lot of users will hit this issue |
|
|
@stevespringett Can you clarify the exact link with the reported issue please? |
|
I'll have to rephrase the title of this PR, as it is confusing: Steve reads it as "cyclonedx-maven-plugin already uses central-publishing-maven-plugin to publish to Maven Central" I should have more time in future weeks to work on cyclonedx-maven-plugin: thanks for the work and patience |
this is the plugin replacing nexus-maven-plugin.
The goal used by this plugin is
publishand notdeployas other oneswe can notice on the output that it is
publish, for instance from https://central.sonatype.org/publish/publish-portal-maven/#publishing[INFO] --- central-publishing-maven-plugin:0.7.0:publish (injected-central-publishing) @ example ---fix #597
Edit: this is about
skipNotDeployeddetection #416 / #435central-publishing-maven-plugin configures all POMs as "maven-deploy-plugin skip" to replace the deployment mechanism: cyclonedx-maven-plugin needs to detect the use of central-publishing-maven-plugin to adapt its "skip" detection approach