ci: fix clippy#428
Merged
Boog900 merged 4 commits intoCuprate:mainfrom Apr 8, 2025
Merged
Conversation
github-actions
Bot
added
A-p2p
hinto-janai
commented
Apr 8, 2025
| tracing::debug!( | ||
| "{lag} transaction broadcast messages were missed, continuing." | ||
| ); | ||
| continue; |
Member
Author
There was a problem hiding this comment.
https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue
Not sure how I feel about these, it guards against code being added/executed below it.
Member
There was a problem hiding this comment.
hmm yeah, probably best to leave this one disabled.
github-actions
Bot
added
A-dependency
Boog900
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes CI with:
with some exceptions.