Conversation
| /// Checks the transaction passes the relay rules. | ||
| /// | ||
| /// Relay rules are rules that govern the txs we accept to our tx-pool and propagate around the network. | ||
| pub fn check_tx_relay_rules( |
There was a problem hiding this comment.
Some questions:
- There seem to be other relay rules not included here, e.g.: https://github.com/monero-project/monero/blob/3b01c490953fe92f3c6628fa31d280a4f0490d28/src/cryptonote_core/tx_pool.cpp#L150-L151, should the diff between
monerodandcupratedrelay rule behavior be documented somewhere? - Should
check_fee/dynamic_base_feehave some tests to make sure it matchesmonerodover time?
There was a problem hiding this comment.
There seem to be other relay rules not included here, e.g.: https://github.com/monero-project/monero/blob/3b01c490953fe92f3c6628fa31d280a4f0490d28/src/cryptonote_core/tx_pool.cpp#L150-L151, should the diff between monerod and cuprated relay rule behavior be documented somewhere?
That one isn't really a relay rule IMO, it just prevents a previously timed out tx from getting added to the pool again.
All relay rules should be included here.
Should check_fee/dynamic_base_fee have some tests to make sure it matches monerod over time?
Probably, I don't know how we would do that without generating txs though so that will have to come later
There was a problem hiding this comment.
There is other code there: https://github.com/monero-project/monero/blob/3b01c490953fe92f3c6628fa31d280a4f0490d28/src/cryptonote_core/tx_pool.cpp#L204-L344.
Should that be replicated here?
There was a problem hiding this comment.
monerod's tx-pool also deals with some consensus checks, only the checks that have m_no_drop_offense = true are relay checks
2 participants
What
Adds tx-pool relay rules to
cuprated.