-
-
Notifications
You must be signed in to change notification settings - Fork 500
London | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/form controls #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmoratti
wants to merge
7
commits into
CodeYourFuture:main
Choose a base branch
from
vmoratti:feature/Form-Controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−24
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
998b7d2
start from scratch again
vmoratti ba18401
add index.htmml file that i wrote before
vmoratti 9c2ee9a
add style.css file, and styling to the <legend> field
vmoratti 4c82518
final commmit
vmoratti 5917059
Enhance name input pattern for international characters
vmoratti f4aa852
Remove extra blank lines in index.html
vmoratti cdafa4c
change pattern=" " requirements in the name field
vmoratti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,72 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| </footer> | ||
| </body> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <fieldset> | ||
| <legend>Name and Email address</legend> | ||
| <!--Adding <legend> element for accessibility purposes--> | ||
| <label for="name">Name</label> | ||
| <input type="text" id="name" name="name" minlength="2" pattern="(?:.*\S){2,}.*" required><br><br> | ||
| <!--Input field for name, making it required--> | ||
| <label for="email">Email:</label> | ||
| <input type="email" id="email" required><br><!--Input field for email address. Making it required--> | ||
| </fieldset> | ||
|
|
||
|
|
||
| <fieldset> | ||
| <legend>Please select a colour for your T-Shirt</legend> | ||
| <label> | ||
| <input type="radio" name="colour" required>Blue | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="colour">Red | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="colour">Green | ||
| </label><!--Making radio buttons for Blue, Red and Green and making the require fields--> | ||
| </fieldset><br> | ||
| <fieldset> | ||
| <legend>Please select a size for your T-Shirt</legend> | ||
| <label> | ||
| <!--Making radio buttons for XS, S, M, L, XL and XXL sizes, and making them required fields--> | ||
| <input type="radio" name="size" required>XS | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="size" >S | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="size">M | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="size">L | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="size">XL | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="size">XXL | ||
| </label> | ||
| </fieldset><br> | ||
| <div> | ||
| <button>Submit</button><!--adding final comment to test push and PR--> | ||
| </div> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <p>By Vito Moratti</p> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| legend { | ||
| font-weight: bold; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you