Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | wireframe #1366
Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | wireframe #1366Abduhasen wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code is error free and well formatted. Page layout is strong. Well done.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
The unordered list in the "Changelist" section of the PR description is not correctly formatted in Markdown. Can you fix it?
There was a problem hiding this comment.
There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.
… to one and also changed the position of footer in to fixed.
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
|


… to the article
Learners, PR Template
Self checklist
Changelist
Questions
N/A