Skip to content

Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Wireframe#1365

Open
asandagwala wants to merge 5 commits into
CodeYourFuture:mainfrom
asandagwala:feature/wireframe
Open

Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Wireframe#1365
asandagwala wants to merge 5 commits into
CodeYourFuture:mainfrom
asandagwala:feature/wireframe

Conversation

@asandagwala
Copy link
Copy Markdown

@asandagwala asandagwala commented May 28, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added semantic HTML structure
  • Styled layout using CSS Grid
  • Added article cards and images
  • Fixed footer positioning
  • Improved accessibility and layout

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 744690d
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a20919d3ae2a1000819f493
😎 Deploy Preview https://deploy-preview-1365--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@asandagwala asandagwala added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@asandagwala asandagwala changed the title Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Wireframe Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Wireframe May 28, 2026
@asandagwala asandagwala added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
cjyuan
cjyuan reviewed May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • To better align with the wireframe, can you

    • Make the page title centered
    • Keep the title and the "Read more" link of articles 2 and 3 fully aligned horizontally
Image

Comment thread Wireframe/index.html Outdated
Comment thread Wireframe/style.css
Comment thread Wireframe/style.css Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@asandagwala asandagwala added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026
cjyuan
cjyuan reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page layout would probably better match the wireframe if the image in articles 2 and 3 have the same height.

More importantly, you should ensure you have successfully enabled "Format on save" in your VS Code.

Comment thread Wireframe/style.css Outdated
Comment on lines +110 to +115
article p {
margin-bottom: 0;
}
article a {
margin-top:20px;
}
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Can you follow the instructions in this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code in both index.html and style.css is consistently formatted.

Copy link
Copy Markdown
Author

@asandagwala asandagwala Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. I have fixed the indentation and the image height on articles 2 & 3

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
@asandagwala asandagwala added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 3, 2026

Changes look good.

Code formatting has been improved, but it does not look like they are formatted by an automated tool. (I will keep nagging if I came across inconsistently formatted code in the future) 😉

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asandagwala @cjyuan